Update LTEngine.kt #470
Merged
Update LTEngine.kt #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the LT default URL, as the terraprint one is no longer hosted. Provided with my instance.
|
Looking at LibreTranslate/LibreTranslate@8e44284#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R428, you checked that it requires an API key. If that's the case, I don't think it should be the default engine, otherwise I'm good with the PR. I tested your instance's API and it doesn't seem to require an API key, so is that just not set up yet or falsely set in the commit at LibreTranslate's Readme? |
|
Sorry, I had the required API key check mark in error, and I have now removed it within readme, but the PR is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the LT default URL, as the terraprint one is no longer hosted. Provided with my instance.