Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

feat: support for only playing music from certain directories #109

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Jun 30, 2024

closes #106

@Bnyro Bnyro requested a review from SuhasDissa June 30, 2024 15:09
@SuhasDissa
Copy link
Member

This works fine as long as the directory names are unique. IMO, It's better than nothing.

Try this to see what I mean,

  • Add a few songs to the Music folder in the SD card.
  • Add some more songs to the Music folder in the internal storage
  • goto app settings and select the Music folder in SD card as the song location.

Expected behavior:

  • App loads songs only from the Music folder in the SD card

Actual behavior:

  • Songs are loaded from the both Music folders in internal storage and SD card

@Bnyro
Copy link
Member Author

Bnyro commented Jul 1, 2024

Songs are loaded from the both Music folders in internal storage and SD card

Yeah, I've considered this too while implementing - but the current way how we query music in combination with Android's DocumentContract API make it really hard to implement this in a better way.

@Bnyro Bnyro merged commit a09dd4a into main Jul 1, 2024
2 checks passed
@Bnyro Bnyro deleted the select-music-folders branch July 1, 2024 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select directories to import music from
2 participants