Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

DARK: Single page accordion do not open #211

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

bj-anas
Copy link
Collaborator

@bj-anas bj-anas commented Apr 1, 2024

Issue

https://youcan-shop.slack.com/archives/C04BDG9HEB1/p1711404546367789

How to get this issue in your theme?

Make sure that you have just 2 accordions and not 3 in your Single page section

Why does it happen?

Screenshot 2024-04-01 at 12 52 51

As we see In this image we have multiple event listeners attached to it causing the accordion to malfunction.

QA Steps

  • pnpm i
  • pnpm run dev
  • Go to product page > Single page section
  • Add 2 accordions
  • Finally, test the functionality & check the dev-tools section

Sorry, something went wrong.

@bj-anas bj-anas added the Ready for review Ready for review label Apr 1, 2024
@bj-anas bj-anas self-assigned this Apr 1, 2024
@bj-anas bj-anas merged commit fb12a15 into main Apr 2, 2024
@bj-anas bj-anas deleted the dark-accordion-issue branch April 2, 2024 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants