Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-6: Theme Editor > Mobile burger menu color is not configurable #10

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

MohamedJamoun
Copy link
Contributor

@MohamedJamoun MohamedJamoun commented Aug 2, 2024

JIRA Ticket

TH-6

QA Steps

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env
  • Test the new menu customization options

Note

Leave empty when you have nothing to say

@MohamedJamoun MohamedJamoun added the in progress Currently being developed. label Aug 2, 2024
@MohamedJamoun MohamedJamoun self-assigned this Aug 2, 2024
@MohamedJamoun MohamedJamoun changed the title TH-6: Theme Editor > Mobile burger menu color is not configurable (cannot change its color) TH-6: Theme Editor > Mobile burger menu color is not configurable Aug 2, 2024
@MohamedJamoun MohamedJamoun added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 2, 2024
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u please update the default color of Aura and Harmony by changing the default white to black? The screenshot below clarifies the issue.

Screenshot 2024-08-05 at 10 35 08
 {
   "type": "color",
   "id": "navbar_menu_icon_color",
   "label": "Icon color",
    "default": "#FFFFFF"
}

themes/aura/sections/main-navbar.liquid Show resolved Hide resolved
themes/harmony/sections/main-navbar.liquid Show resolved Hide resolved
themes/meraki/sections/main-navbar.liquid Show resolved Hide resolved
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 7, 2024
@MohamedJamoun MohamedJamoun merged commit 94376eb into master Aug 7, 2024
@MohamedJamoun MohamedJamoun deleted the TH-6 branch August 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants