Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-68: Preload google font #20

Merged
merged 7 commits into from
Aug 12, 2024
Merged

TH-68: Preload google font #20

merged 7 commits into from
Aug 12, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Aug 7, 2024

Note

This change doesn't have any significant performance improvement but it is recommended to preconnect resources like fonts to reduce the initial latency involved in DNS lookups

JIRA Ticket

Ticket: TH-68.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • See code

@eihabkhan1 eihabkhan1 self-assigned this Aug 7, 2024
@eihabkhan1 eihabkhan1 added the in progress Currently being developed. label Aug 7, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the css files in this PR as the change made to their scss counterpart wasn't applied to them here
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, but there is a possibility that another scenario may require the same solution. Please refer to the source below:
main-navbar.liquid

{%- if section.settings.navbar_font_family -%}
    <link
      href='https://fonts.googleapis.com/css2?family={{ section.settings.navbar_font_family }}:ital,wght@0,300;0,400;0,500;0,700;1,400&display=swap'
      rel='stylesheet'
    >
{%- endif -%}

@eihabkhan1 eihabkhan1 added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 8, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review August 8, 2024 09:28
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 8, 2024
@eihabkhan1 eihabkhan1 merged commit efe8769 into master Aug 12, 2024
@eihabkhan1 eihabkhan1 deleted the TH-68 branch August 12, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants