Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-71: Product Page > Fix Dropdown not applying default value #21

Merged
merged 9 commits into from
Aug 13, 2024
Merged

TH-71: Product Page > Fix Dropdown not applying default value #21

merged 9 commits into from
Aug 13, 2024

Conversation

eihabkhan
Copy link
Member

@eihabkhan eihabkhan commented Aug 9, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH-71.

Prerequisites

  • Make sure you have at least one product
  • Make sure that the product have two variants
  • Make sure that the one of the variant types is Radio Button and the other is Dropdown List
Screenshot 2024-08-13 at 4 20 18 PM * [ ] ensure that no default variant is defined

QA Steps

@eihabkhan eihabkhan self-assigned this Aug 9, 2024
@eihabkhan eihabkhan added the in progress Currently being developed. label Aug 9, 2024
@eihabkhan eihabkhan changed the title TH-71: Fix console errors TH-71: Fix Dropdown not applying default value Aug 13, 2024
@eihabkhan eihabkhan changed the title TH-71: Fix Dropdown not applying default value TH-71: Product Page > Fix Dropdown not applying default value Aug 13, 2024
@eihabkhan eihabkhan marked this pull request as ready for review August 13, 2024 15:13
@eihabkhan eihabkhan added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 13, 2024
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 13, 2024
@eihabkhan eihabkhan merged commit 42529ab into master Aug 13, 2024
@eihabkhan eihabkhan deleted the TH-71 branch August 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrilBadreddine ibrilBadreddine ibrilBadreddine approved these changes

Assignees

@eihabkhan eihabkhan

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan @ibrilBadreddine