Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-79: All themes > Performance > Every <img> tag must include an "alt" attribute #23

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

ibrilBadreddine
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine commented Aug 13, 2024

JIRA Ticket

Ticket: TH-79.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • Go to https://seller-area.youcan.shop/admin/themes
  • Try to active Aura or Meraki or Harmony theme -> Preview
  • Verify if all theme images have alt attribute
    1 - Manual Check: Browse each page in your store and manually inspect each image to ensure it has an alt attribute.
    2 - Quick Check: In your IDE, search for <img and alt=. If both searches return the same number of results, you're set!

Important

Use both methods, because double-checking is double the fun!

Note

Leave empty when you have nothing to say.

@ibrilBadreddine ibrilBadreddine added the in progress Currently being developed. label Aug 13, 2024
@ibrilBadreddine ibrilBadreddine self-assigned this Aug 13, 2024
@ibrilBadreddine ibrilBadreddine added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 13, 2024
Copy link
Contributor

@bj-anas bj-anas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 15, 2024
@ibrilBadreddine ibrilBadreddine merged commit c7cd45b into master Aug 15, 2024
@ibrilBadreddine ibrilBadreddine deleted the TH-79 branch August 15, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants