Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-80: Product Page > Variants Images not showing when clicked (Mobile) #24

Merged
merged 10 commits into from
Aug 16, 2024

Conversation

eihabkhan
Copy link
Member

@eihabkhan eihabkhan commented Aug 15, 2024

JIRA Ticket

Ticket: TH-80.

Prerequisites

  • Make sure to have at least one product with a few variants, to make things easy for you, create this product:

    • Title: حذاء لورو بيانا
    • Description: حذاء موكاسين رياضي مصنوع من الجلد السويدي الناعم والمريح للغاية. النعل مصنوع من المطاط، وهي ميزة تميز جميع أحذية لورو بيانا الرياضية. الحذاء مزين بشريط صغير في الأمام مع دلايات "My Charms" المصغرة. يعد اختيارًا مثاليًا للصيف، سواء كنت ستقضين يومك على الشاطئ، في زيارة العائلة، أو في الخروج مع الأصدقاء.
    • Price: 250
    • Images
      rkuBdZ0iYgQCDNNuNiHKLZUpXXHVMbXHOtSDOjjG
      cjsW8J0lBcRl8UbpJiD2NtpwYH72htUcssCAq1AX
      pik8HZgpv3bY2zpiX0h8PlCADGrTFkl1JIiXEhp7
      pxu4jwOtGH4NsiwKaa5x8uiGYZP5cJpH2L9guz3k
  • Add variants to this product, preferibly of type Dropdown List variant with the following values:

    • Bleu Ciel
    • Marron
    • Beige
    • Vert
  • Make sure to assign images to their respective variant, once that's done you can commence the QA steps
    Screenshot 2024-08-15 at 2 39 23 PM

QA Steps

  • Go to your product page
  • Switch to mobile view
    • Open the dev tools (⌘ + ⌥ + I)
    • Toggle the device toolbar (⌘ + ⇧ + M)
    • Choose a mobile device from the top bar (e.g iPhone 12 Pro)
    • Try to change the product images, the main image should change accordingly
    • Now try switching the variant from the dropdown list, the image should update accordingly

@eihabkhan eihabkhan self-assigned this Aug 15, 2024
@eihabkhan eihabkhan added the in progress Currently being developed. label Aug 15, 2024
@eihabkhan eihabkhan added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 15, 2024
@eihabkhan eihabkhan marked this pull request as ready for review August 15, 2024 13:44
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 16, 2024
@eihabkhan eihabkhan merged commit 5e7c4e3 into master Aug 16, 2024
@eihabkhan eihabkhan deleted the TH-80 branch August 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants