Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-78: All themes > Performance > Optimize default images #26

Merged
merged 16 commits into from
Aug 22, 2024
Merged

TH-78: All themes > Performance > Optimize default images #26

merged 16 commits into from
Aug 22, 2024

Conversation

ibrilBadreddine
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine commented Aug 16, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH-78.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

Screenshot 2024-08-16 at 17 22 43
  • Verify that avatar & product images are 30% smaller.
  • Ensure PNG icons are swapped with library icons.
Screenshot 2024-08-16 at 17 25 23
  • Confirm theme logos have proper width/height.
Screenshot 2024-08-16 at 17 26 07
  • Check logos are upgraded to SVGs.

Important

  • Validate a 95% performance score and 1s Speed Index.
  • The last issue will be handled separately once the design team finishes the new logos.

Note

Leave empty when you have nothing to say.

@ibrilBadreddine ibrilBadreddine added the in progress Currently being developed. label Aug 16, 2024
@ibrilBadreddine ibrilBadreddine self-assigned this Aug 16, 2024
@ibrilBadreddine ibrilBadreddine added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 22, 2024
bj-anas
bj-anas approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@bj-anas bj-anas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 22, 2024
@ibrilBadreddine ibrilBadreddine merged commit bd46717 into master Aug 22, 2024
@ibrilBadreddine ibrilBadreddine deleted the TH-78 branch August 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bj-anas bj-anas bj-anas approved these changes

Assignees

@ibrilBadreddine ibrilBadreddine

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibrilBadreddine @bj-anas