Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-74: All themes > Performance > Eliminate render-blocking resources #31

Merged
merged 6 commits into from
Aug 28, 2024
Merged

TH-74: All themes > Performance > Eliminate render-blocking resources #31

merged 6 commits into from
Aug 28, 2024

Conversation

ibrilBadreddine
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine commented Aug 22, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH-74.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • See code 🙂

Important

Please read the ticket description.

Note

Leave empty when you have nothing to say.

@ibrilBadreddine ibrilBadreddine added the in progress Currently being developed. label Aug 22, 2024
@ibrilBadreddine ibrilBadreddine self-assigned this Aug 22, 2024
@ibrilBadreddine ibrilBadreddine added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 23, 2024
eihabkhan1
eihabkhan1 requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@eihabkhan1 eihabkhan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question, why do we preload notice-bar.css out of all css files?

themes/aura/sections/main-navbar.liquid Show resolved Hide resolved
themes/aura/sections/main-navbar.liquid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already preconnect to google fonts in head-config which is called before main-navbar

@eihabkhan1 eihabkhan1 added requested changes and removed Ready for review Requires a review from another developer. labels Aug 26, 2024
@ibrilBadreddine ibrilBadreddine added Ready for review Requires a review from another developer. and removed requested changes labels Aug 28, 2024
@ibrilBadreddine ibrilBadreddine merged commit 504d15b into master Aug 28, 2024
@ibrilBadreddine ibrilBadreddine deleted the TH-74 branch August 28, 2024 10:11
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eihabkhan1 eihabkhan1 eihabkhan1 approved these changes

Assignees

@ibrilBadreddine ibrilBadreddine

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibrilBadreddine @eihabkhan1