Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-16: Storefront > issue of popup alerts not translated #32

Merged
merged 3 commits into from
Aug 26, 2024
Merged

TH-16: Storefront > issue of popup alerts not translated #32

merged 3 commits into from
Aug 26, 2024

Conversation

MohamedJamoun
Copy link
Contributor

@MohamedJamoun MohamedJamoun commented Aug 23, 2024 •
edited by jira bot
Loading

JIRA Ticket

Ticket: TH-16.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env
  • Use a product with an image variant
  • Try to upload an image over 2MB
  • You should see an error with your store language

QA Steps

  • Go to /something
  • Verify said thing

Note

Leave empty when you have nothing to say.

@MohamedJamoun MohamedJamoun added the Ready for review Requires a review from another developer. label Aug 23, 2024
@MohamedJamoun MohamedJamoun self-assigned this Aug 23, 2024
bj-anas
bj-anas approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@bj-anas bj-anas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 26, 2024
@MohamedJamoun MohamedJamoun merged commit c68a7b8 into master Aug 26, 2024
@MohamedJamoun MohamedJamoun deleted the TH-16 branch August 26, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bj-anas bj-anas bj-anas approved these changes

Assignees

@MohamedJamoun MohamedJamoun

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MohamedJamoun @bj-anas