Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DARK: Meraki > Discard comments + Autoprefixer #36

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

eihabkhan1
Copy link
Collaborator

Note

Don't get startled by the large number of changed files, most of those changes are the result of installing and using postCSS plugins

JIRA Ticket

DARK

Prerequisites

  • Make sure to have this repo cloned and setup locally on your machine
  • cd into the project
  • Make sure you have all packages installed pnpm i

QA Steps

  • cd into /themes/aura.
  • Run pnpm dev.

Testing existing files

  • Inspect main.scss, you'll notice that there are comments in that file.
  • Inspect main.css. Ensure that there are no comments there.

Testing new files

  • Create a new SCSS file in /styles, call it test.scss for example.
  • Add a multi-line comment and define some arbitrary CSS rule:
/*
* This comment shouldn't be carried out to the .css file
*/

.foo {
    color: red;
}
  • Once you save the file a .css counterpart should be generated in /assets.
  • Open the newly generated css file (/assets/test.css).
  • Ensure that the comment isn't there and that white spaces were reduced, this is how the output should look like:
.foo{
  color:red;
}

@eihabkhan1 eihabkhan1 self-assigned this Aug 27, 2024
@eihabkhan1 eihabkhan1 added the Ready for review Requires a review from another developer. label Aug 27, 2024
@AliHMIMS AliHMIMS added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 27, 2024
@eihabkhan1 eihabkhan1 merged commit f613649 into master Aug 27, 2024
@eihabkhan1 eihabkhan1 deleted the tooling-meraki branch August 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants