Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-70: Theme editor > No way of clearing navbar's font-family #38

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

ibrilBadreddine
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine commented Aug 28, 2024

JIRA Ticket

Ticket: TH_70.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

Important

If you're installing for the first time, when you check the navbar font family, it should have a default option selected automatically (the font family of your theme should be the default), instead of being empty. In the future, if you update the font family of the navbar and want to revert to the original setting, you can simply select the default option to set it back to the original font family.

Preview

Screenshot 2024-08-28 at 12 13 18

Note

Leave empty when you have nothing to say.

@ibrilBadreddine ibrilBadreddine added the Ready for review Requires a review from another developer. label Aug 28, 2024
@ibrilBadreddine ibrilBadreddine self-assigned this Aug 28, 2024
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 28, 2024
@ibrilBadreddine ibrilBadreddine merged commit 6bd15db into master Aug 28, 2024
@ibrilBadreddine ibrilBadreddine deleted the TH-70 branch August 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants