Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-92: All themes > Performance > Audit 1 > Fix the accessibly issues #41

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

ibrilBadreddine
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine commented Sep 2, 2024

JIRA Ticket

Ticket: TH_92.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • Go to https://seller-area.youcan.shop/admin/themes
  • Try to active Aura or Meraki or Harmony theme -> Preview
  • Please make sure of the following:
    • The title in the feature products section should have an <h1> instead of an <h2> tag.
    • No layout shirt on the slider section after the height change.
    • Cart page > remove item & quantity inputs, now have a label.

Note

Leave empty when you have nothing to say.

@ibrilBadreddine ibrilBadreddine added the in progress Currently being developed. label Sep 2, 2024
@ibrilBadreddine ibrilBadreddine self-assigned this Sep 2, 2024
@ibrilBadreddine ibrilBadreddine added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Sep 2, 2024
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Sep 3, 2024
@ibrilBadreddine ibrilBadreddine merged commit 6345322 into master Sep 3, 2024
@ibrilBadreddine ibrilBadreddine deleted the TH-92 branch September 3, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants