Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-1: Customize the display of the slider image on mobile/desktop screen #45

Merged
merged 4 commits into from
Sep 3, 2024
Merged

TH-1: Customize the display of the slider image on mobile/desktop screen #45

merged 4 commits into from
Sep 3, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Sep 3, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH_1.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • In theme editor choose slider section
  • Add an image if it's not added and choose an image for desktop and another one for mobile

Screenshot

Screenshot 2024-09-03 at 16 23 28

@bj-anas bj-anas added the in progress Currently being developed. label Sep 3, 2024
@bj-anas bj-anas self-assigned this Sep 3, 2024
@bj-anas bj-anas added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Sep 3, 2024
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Sep 3, 2024
@bj-anas bj-anas merged commit 96c639f into master Sep 3, 2024
@bj-anas bj-anas deleted the TH-1 branch September 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrilBadreddine ibrilBadreddine ibrilBadreddine approved these changes

Assignees

@bj-anas bj-anas

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj-anas @ibrilBadreddine