Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark - fixing the direction of the arrows #51

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Sep 23, 2024

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • Go to collection page
  • Check the direction of the arrows is correct based on the page direction

Note

I have also pushed some auto generated CSS files because I noticed that sometimes we don't push them or we made some changes directly on them and we forget to make those changes on SCSS files

@bj-anas bj-anas added the Ready for review Requires a review from another developer. label Sep 23, 2024
@bj-anas bj-anas self-assigned this Sep 23, 2024
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Sep 24, 2024
@bj-anas bj-anas merged commit 29c73bb into master Sep 24, 2024
@bj-anas bj-anas deleted the DARK-fixing-arrows-direction branch September 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants