Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-155-meraki: Format product price in product page based on a unified locale code #57

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Oct 8, 2024

JIRA Ticket

Ticket: TH-155.

Prerequisites

  • Make sure you have at least one product in your store
  • Make sure you have Aura theme active

QA Steps

Multi Currency ON

  • From the multi currency settings in seller area, turn on multi currency and enable precision
  • Turn on your VPN
  • Go to your product's page in storefront
  • Make sure that:
    • The price (value) is formatted based on your VPN's country + your browser's language
    • The price is converted to your VPN's country currency
    • The currency symbol displayed is the VPN's country currency symbol
  • Go to your browser's language settings, If you're using Chrome just click ⌘ + ,
  • Search for language
Screenshot 2024-10-08 at 8 43 12 AM * [ ] Click the three dots next to any language and move it to the top to make it your language of choice * [ ] Go back to your product page and hit refresh * [ ] The price value should be formatted based on your VPN + your browser's language

Multi Currency OFF

  • From the multi currency settings in seller area, turn off multi currency and enable precision
  • Go to your store's general settings /admin/settings/general#details
  • Change the store language to English - United States
  • Change the store currency to Moroccan Dirhams
  • Change the currency symbol to MAD
  • Go to your product page
  • Hit refresh, make sure that:
    • The price (value) is formatted based on your store country
    • The currency symbol displayed is the symbol you defined in your store (in this case it should be MAD)
  • Go back to your store, change the language to French - France
  • Go back to the product page, hit refresh
  • The price should be formatted accordingly and the currency symbol should be on the right
  • Go back to your store, this time change the currency symbol to a random currency symbol (ex: Wiwi)
  • Go back to your product page, hit refresh
  • The price should be formatted accordingly and the currency symbol should still be on the right

Note

Leave empty when you have nothing to say.

@eihabkhan1 eihabkhan1 self-assigned this Oct 8, 2024
@eihabkhan1 eihabkhan1 added in progress Currently being developed. Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Oct 8, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review October 8, 2024 09:13
@eihabkhan1 eihabkhan1 changed the title TH-155-meraki: add money formatter method TH-155-meraki: Format product price in product page based on a unified locale code Oct 8, 2024
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Oct 8, 2024
@eihabkhan1 eihabkhan1 merged commit 863dc88 into master Oct 8, 2024
@eihabkhan1 eihabkhan1 deleted the TH-155-meraki branch October 8, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants