Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-176-harmony: Fix logo squished in mobile cart #60

Merged
merged 3 commits into from
Oct 14, 2024
Merged

TH-176-harmony: Fix logo squished in mobile cart #60

merged 3 commits into from
Oct 14, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Oct 10, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH-176.

QA Steps

  • Go to /admin/themes
  • Activate Harmony
  • Go to theme editor
  • Switch to mobile view
  • Click on the burger menu icon
  • From the properties panel, upload a logo, any image will do
  • After the image is uploaded hit save
  • Open the sidemenu
  • The should be well proportioned and not squished

Note

Leave empty when you have nothing to say.

@eihabkhan1 eihabkhan1 self-assigned this Oct 10, 2024
@eihabkhan1 eihabkhan1 added the Ready for review Requires a review from another developer. label Oct 10, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review October 10, 2024 16:06
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Oct 14, 2024
@eihabkhan1 eihabkhan1 merged commit 39077b9 into master Oct 14, 2024
@eihabkhan1 eihabkhan1 deleted the TH-176-harmony branch October 14, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bj-anas bj-anas bj-anas approved these changes

Assignees

@eihabkhan1 eihabkhan1

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan1 @bj-anas