-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TH-174: Aura > Cart Page > Format product price by the Dotshop object's locale code #64
Open
eihabkhan1
wants to merge
14
commits into
master
Choose a base branch
from
TH-174-aura
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+250
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart.js needs to be refactored: https://youtu.be/mWMFTfaJaWM |
eihabkhan1
added
Ready for review
Requires a review from another developer.
and removed
in progress
Currently being developed.
labels
Oct 21, 2024
|
eihabkhan1
added
in progress
Currently being developed.
and removed
Ready for review
Requires a review from another developer.
labels
Dec 10, 2024
bj-anas
added
Ready for review
Requires a review from another developer.
and removed
in progress
Currently being developed.
labels
Dec 17, 2024
bj-anas
changed the title
TH-174-aura: Aura > Format prices in cart page
TH-174: Aura > Cart Page > Format product price by the Dotshop object's locale code
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Ticket: TH-174.
Prerequisites
QA Steps
Multi Currency OFF
/admin/settings/general#details
English - United States
Moroccan Dirhams
MAD
French - France
Wiwi
)Multi Currency ON
⌘ + ,
Note
Note that if your IP address while using VPN is in UK, and you have Arabic as the browser language, then you might see a flash where the price is displayed in indic numerals at first then Arabic numbers
١٢٣.٩٩ ' ->
123.99`. This is likely an issue with how PHP handles ar-GB vs how javaScript handles it. Will tackle this issue in a separate PR.Note
Leave empty when you have nothing to say.