-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TH-174: Aura > Cart Page > Format product price by the Dotshop object's locale code #64
Conversation
cart.js needs to be refactored: https://youtu.be/mWMFTfaJaWM |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
I tried QA with the add to cart
feature on, but clicking any product card (home or collections) triggered this error:
add-to-cart.js
-> directAddToCart
function
Uncaught (in promise) ReferenceError: trackVariantQuantityOnCart is not defined
You have some problems with syncing files while you running the dev mode in your local machine |
JIRA Ticket
Ticket: TH-174.
Prerequisites
QA Steps
Multi Currency OFF
/admin/settings/general#details
English - United States
Moroccan Dirhams
MAD
French - France
Wiwi
)Multi Currency ON
⌘ + ,
Note
Note that if your IP address while using VPN is in UK, and you have Arabic as the browser language, then you might see a flash where the price is displayed in indic numerals at first then Arabic numbers
١٢٣.٩٩ ' ->
123.99`. This is likely an issue with how PHP handles ar-GB vs how javaScript handles it. Will tackle this issue in a separate PR.Note
Leave empty when you have nothing to say.