Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-109: Meraki > Product page > Prevent the customer from placing an order if a variant is out of stock #69

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Oct 21, 2024

JIRA Ticket

Ticket: TH_109.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

This QA will be focused only on Product page

  • First make sure that you have activated track inventory on your product.
  • Set the tracking inventory number on a product (if it have variants scroll down open the variants accordion, under the Untracked input set a number on each variant.
  • Now under the product page of your store front try to choose a higher stock than the available you will see a popup notification warning or if the stock is 0 you won't even be able to click on the add to cart button or express checkout button as well you will see them disabled.
  • The behaviour that you expect to happen when you have a product that have many variants based on its own inventory you supposed to see this:
    - variant has 0 inventory: express checkout & cart buttons are disabled
    - variant has 2 on inventory : max quantity that the customer can add to cart is 2 if try to add more the popup notification warning show up
    - variant has 2 on inventory and 2 on cart: the popup notification warning show up

Note

I have also fix some CSS issues on Express checkout form

@bj-anas bj-anas added the Ready for review Requires a review from another developer. label Oct 21, 2024
@bj-anas bj-anas self-assigned this Oct 21, 2024
@bj-anas bj-anas merged commit 9b9ac7d into master Oct 21, 2024
@bj-anas bj-anas deleted the TH-109-meraki-product-page branch October 21, 2024 13:12
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants