Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DARK : Fix express checkout block CSS #71

Merged
merged 3 commits into from
Oct 22, 2024
Merged

DARK : Fix express checkout block CSS #71

merged 3 commits into from
Oct 22, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Oct 21, 2024 •
edited
Loading

issue

Before
Screenshot 2024-10-21 at 14 51 59

After
Screenshot 2024-10-21 at 15 14 08

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • Go to seller area > All product > edit product
  • First make sure that you have activated track inventory feature on your product.
  • Set in the input of the tracking inventory: 0 (if it has variants scroll down and open the variants accordion, under the Untracked input set 0.
  • Go to theme editor make: Product page > single product section > express checkout block
  • Disable the sticky switch button

@bj-anas bj-anas added the in progress Currently being developed. label Oct 21, 2024
@bj-anas bj-anas self-assigned this Oct 21, 2024
@bj-anas bj-anas added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Oct 21, 2024
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Oct 22, 2024
@bj-anas bj-anas merged commit 44d2a6f into master Oct 22, 2024
@bj-anas bj-anas deleted the DARK-fix-express-checkout-css branch October 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrilBadreddine ibrilBadreddine ibrilBadreddine approved these changes

Assignees

@bj-anas bj-anas

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj-anas @ibrilBadreddine