Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-187: Meraki > Refactoring skip cart feature #74

Merged
merged 1 commit into from
Oct 24, 2024
Merged

TH-187: Meraki > Refactoring skip cart feature #74

merged 1 commit into from
Oct 24, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Oct 23, 2024 •
edited
Loading

JIRA Ticket

Ticket: [TH_ 187](https://youcanshop.atlassian.net/browse/TH_ 187).

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • in seller-area activate skip cart feature
  • now in your meraki theme
  • Go to product page and click on the cta button normally it should take you to the checkout page directly
  • If you activate direct add to cart in the theme editor it will be overridden by skip cart so you should go to the product page then the cta button will take you to the checkout page

@bj-anas bj-anas added the Ready for review Requires a review from another developer. label Oct 23, 2024
@bj-anas bj-anas self-assigned this Oct 23, 2024
@eihabkhan1 eihabkhan1 added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Oct 24, 2024
@bj-anas bj-anas merged commit ba9ef26 into master Oct 24, 2024
@bj-anas bj-anas deleted the TH-187-meraky branch October 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eihabkhan1 eihabkhan1 eihabkhan1 approved these changes

Assignees

@bj-anas bj-anas

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj-anas @eihabkhan1