Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-186 New themes > Express checkout > Max checkout amount error is missing #75

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Oct 24, 2024

JIRA Ticket

Ticket: TH-186.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • In seller-area > Settings > General > Max checkout amount | Max checkout quantity
  • Try to put low values
  • Now go to product page and use the express checkout method to buy the product and make sure that choose high values than max checkout amount or max checkout quantity
  • Normally you will see a popup error show the detail of that error

Note

  • Please make sure to upload theme on you Prod account in seller area and do not use dev mode because it will not gonna work.
  • I have also faced this issue (we got the backend content mixed with some HTML) I did a temporary fix until we find out how to solve it.
Screenshot 2024-10-24 at 16 03 25

@bj-anas bj-anas added the Ready for review Requires a review from another developer. label Oct 24, 2024
@bj-anas bj-anas self-assigned this Oct 24, 2024
@bj-anas bj-anas merged commit c01eaae into master Oct 25, 2024
@bj-anas bj-anas deleted the TH-186 branch October 25, 2024 13:23
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants