Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-204: Meraki > Js errors show up as notification alerts #79

Merged
merged 3 commits into from
Oct 30, 2024
Merged

TH-204: Meraki > Js errors show up as notification alerts #79

merged 3 commits into from
Oct 30, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Oct 30, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH_204.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • In theme editor remove all default sections and set only the section of single product inside the home page
  • add those blocks: title, price, reviews, express checkout
  • check devtools for any bugs

Changes that have been made:

  • Removing reviews-count.js file
  • Setting fetchReviewsForProduct() function in the main.js file so that can be globally accessible
  • Remove TRANSLATED_TEXT variable cause we have ADD_TO_CART_EXPECTED_ERRORS variable that's globally accessible
  • Add condition for updating quantityInput
  • Fix product column section CSS and JS

@bj-anas bj-anas added the Ready for review Requires a review from another developer. label Oct 30, 2024
@bj-anas bj-anas self-assigned this Oct 30, 2024
@bj-anas bj-anas merged commit fdb6dec into master Oct 30, 2024
@bj-anas bj-anas deleted the TH-204-meraki branch October 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eihabkhan1 eihabkhan1 eihabkhan1 approved these changes

Assignees

@bj-anas bj-anas

Labels
Ready for review Requires a review from another developer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj-anas @eihabkhan1