Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DARK: reverting changes of 4.2.5 release in express-checkout.js #80

Merged
merged 1 commit into from
Oct 30, 2024
Merged

DARK: reverting changes of 4.2.5 release in express-checkout.js #80

merged 1 commit into from
Oct 30, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Oct 30, 2024 •
edited by jira bot
Loading

Ticket

TH-186

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • Go to /something
  • Verify said thing

Note

Leave empty when you have nothing to say.

@bj-anas bj-anas added the Ready for review Requires a review from another developer. label Oct 30, 2024
@bj-anas bj-anas self-assigned this Oct 30, 2024
@eihabkhan1
Copy link
Collaborator

Reason of revert: https://youcan-shop.slack.com/archives/C04BDG9HEB1/p1730306130514889

@bj-anas bj-anas merged commit 22293ea into master Oct 30, 2024
@bj-anas bj-anas deleted the dark-reverting-express-checkout-change branch October 30, 2024 21:49
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eihabkhan1 eihabkhan1 eihabkhan1 approved these changes

Assignees

@bj-anas bj-anas

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bj-anas @eihabkhan1