Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-32: Harmony > Default values in theme editor > should be localized not hard coded in Arabic #82

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Nov 4, 2024

JIRA Ticket

Ticket: TH-32.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • Upload Harmony theme in your Prod account
  • In theme-editor remove all the default sections available
  • Now check the default translation based on your store language for this list:
    - Notice bar > content
    - Footer > Copyright text
    - Slider > slider image > button text
    - Featured products > title
    - Featured collection > title
    - Product slider > title & message
    - Single product > blocks > (stock, express checkout, add to cart, countdown timer)
    - Product column > button text
    - Product page > Related product > title
    - Product reviews > title
    - Thank you page > (title, subtitle, description)

Note

  • I have been forced to update themes/aura/templates/thankyou.json to make the dynamic default content available, another reason we cannot delete the thankyou page section from the theme editor. After testing putting custom text and then releasing it in test env it seems all good the custom text still appears and hasn't been deleted.
  • There is a bug to be fixed in rich-text component of YouCan UI, sometimes you will notice that the default translation isn't available because if the component has empty value it will push by default (<p><br></p>) so the default translation will not be displayed
  • I have also do: corrected typo mistakes, fixed text alignment, removed unused translation keys, and corrected some liquid conditions.

@bj-anas bj-anas added the Ready for review Requires a review from another developer. label Nov 4, 2024
@bj-anas bj-anas self-assigned this Nov 4, 2024
@bj-anas bj-anas added in progress Currently being developed. and removed Ready for review Requires a review from another developer. labels Nov 5, 2024
@bj-anas bj-anas added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Nov 5, 2024
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Nov 21, 2024
@bj-anas bj-anas merged commit 1422242 into master Nov 21, 2024
@bj-anas bj-anas deleted the TH-32-harmony branch November 21, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants