Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-211: Harmony > Fix product & featured products sliders direction not same as document direction #84

Merged
merged 3 commits into from
Nov 8, 2024
Merged

TH-211: Harmony > Fix product & featured products sliders direction not same as document direction #84

merged 3 commits into from
Nov 8, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Nov 7, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH-211.

Prerequisites

  • Have a product slider in the homepage
  • Have a product with related products attached to it
  • Have multi-currency active
  • Have VPN turned OFF
  • Have the Theme direction be RTL
  • Make sure your browser's language is set to French

QA Steps

Product Slider

  • Go to your storefront (homepage)
  • Scroll to the product slider
  • The product prices should be د.م xxx (The currency symbol is on the left)

Related Products Slider

  • Go to the product page of the product that you have related products attached to.
  • Scroll to the related products slider
  • The product prices should be د.م xxx (The currency symbol is on the left)

Note

Leave empty when you have nothing to say.

@eihabkhan1 eihabkhan1 self-assigned this Nov 7, 2024
@eihabkhan1 eihabkhan1 added the in progress Currently being developed. label Nov 7, 2024
@eihabkhan1 eihabkhan1 changed the title TH-211: Fix product slider direction not same as document direction TH-211: Harmony > Fix product slider direction not same as document direction Nov 7, 2024
@eihabkhan1 eihabkhan1 changed the title TH-211: Harmony > Fix product slider direction not same as document direction TH-211: Harmony > Fix product & featured products sliders direction not same as document direction Nov 7, 2024
@eihabkhan1 eihabkhan1 added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Nov 7, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review November 7, 2024 11:18
@eihabkhan1 eihabkhan1 merged commit 4418c1a into master Nov 8, 2024
@eihabkhan1 eihabkhan1 deleted the TH-211-harmony branch November 8, 2024 09:49
@eihabkhan1 eihabkhan1 added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bj-anas bj-anas bj-anas approved these changes

Assignees

@eihabkhan1 eihabkhan1

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan1 @bj-anas