Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-211: Meraki > Fix product & featured products sliders direction not same as document direction #86

Merged
merged 4 commits into from
Nov 8, 2024
Merged

TH-211: Meraki > Fix product & featured products sliders direction not same as document direction #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ad8645
fix product slider direction
eihabkhan1 Nov 7, 2024
9f34e23
remove commented code
eihabkhan1 Nov 7, 2024
f534b0b
fix related product slider
eihabkhan1 Nov 7, 2024
ab6d821
undo perPage fix - will do it in a separate PR
eihabkhan1 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions themes/meraki/sections/featured-product-slider.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
perMove: 1,
snap: true,
gap: '20px',
direction: '{{ settings.theme_direction }}',
});

const mobileBlocksPerPage = {{ section.settings.slider_mobile_per_page }};
Expand All @@ -88,6 +89,7 @@
perMove: 1,
gap: '12px',
snap: true,
direction: '{{ settings.theme_direction }}',
});

mountSlider(isMobile, mobileSlider, desktopSlider);
Expand Down
2 changes: 2 additions & 0 deletions themes/meraki/sections/related-products.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
snap: true,
gap: '20px',
focus: 'center',
direction: '{{ settings.theme_direction }}'
});

const mobileBlocksPerPage = 2;
Expand All @@ -66,6 +67,7 @@
perMove: 1,
gap: '12px',
snap: true,
direction: '{{ settings.theme_direction }}'
});

mountSlider(isMobile, mobileSlider, desktopSlider);
Expand Down
7 changes: 7 additions & 0 deletions themes/meraki/snippets/product-slider.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@
fill: #000;
}

[dir=rtl] #yc_slider_{{ id }} .splide__arrows--rtl .splide__arrow--next {
left: -7rem;
}

[dir=rtl] #yc_slider_{{ id }} .splide__arrows--rtl .splide__arrow--prev {
right: -7rem;
}
{% endstyle %}

{% assign products_exist = false %}
Expand Down
10 changes: 10 additions & 0 deletions themes/meraki/snippets/related-products-slider.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,16 @@
width: 16px;
fill: #000;
}

[dir=rtl] #yc_slider_{{ id }} .splide__arrows--rtl .splide__arrow--next {
border-radius: 8px 0 0 8px;
left: -26rem;
}

[dir=rtl] #yc_slider_{{ id }} .splide__arrows--rtl .splide__arrow--prev {
border-radius: 0 8px 8px 0;
right: -26rem;
}
{% endstyle %}
<div
class='splide yc-slider__{{ view }}'
Expand Down