Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-214: All themes > Fix related products slider perPage #87

Merged
merged 1 commit into from
Nov 8, 2024
Merged

TH-214: All themes > Fix related products slider perPage #87

merged 1 commit into from
Nov 8, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Nov 7, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH-214.

Prerequisites

  • You'll need a product that has at least 5 related products.

QA Steps

Note

Repeat these steps for Aura, Harmony, and Meraki

  • Go to the page of the product that has the related products
  • Verify that no more than 3 products are displayed per page

Aura

Before After
Screenshot 2024-11-07 at 3 29 42 PM Screenshot 2024-11-07 at 3 29 53 PM

Harmony

Before After
Screenshot 2024-11-07 at 3 26 44 PM Screenshot 2024-11-07 at 3 26 53 PM

Meraki

Before After
Screenshot 2024-11-07 at 3 30 37 PM Screenshot 2024-11-07 at 3 33 34 PM

Note

Leave empty when you have nothing to say.

@eihabkhan1 eihabkhan1 self-assigned this Nov 7, 2024
@eihabkhan1 eihabkhan1 added in progress Currently being developed. Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Nov 7, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review November 7, 2024 14:44
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Nov 8, 2024
@eihabkhan1 eihabkhan1 merged commit f2c756c into master Nov 8, 2024
@eihabkhan1 eihabkhan1 deleted the TH-214 branch November 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrilBadreddine ibrilBadreddine ibrilBadreddine approved these changes

Assignees

@eihabkhan1 eihabkhan1

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan1 @ibrilBadreddine