Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DARK: package.json > Bump packageManager and engines versions #89

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

eihabkhan
Copy link
Member

@eihabkhan eihabkhan commented Nov 15, 2024

JIRA Ticket

dark

QA Steps

Node

  • Try running pnpm release
  • If your node version is earlier than 22.11.0, you should get an error
  • If your node version is ^22.11.0, the script should run without any issue

PNPM

  • Try running pnpm release
  • If your pnpm version is earlier than 9.13.0, you should get an error
  • If your pnpm version is ^9.13.0, the script should run without any issue

Note

To update your pnpm version you first need to determine how you installed it:

  • With npm: npm i -g pnpm
  • Wtih homebrew brew upgrade pnpm
  • With pnpm: pnpm i -g pnpm

@eihabkhan eihabkhan self-assigned this Nov 15, 2024
@eihabkhan eihabkhan added the Ready for review Requires a review from another developer. label Nov 15, 2024
@eihabkhan eihabkhan marked this pull request as ready for review November 19, 2024 10:03
@eihabkhan eihabkhan changed the title DARK: Bump pnpm version DARK: package.json > Bump packageManager and engines versions Nov 19, 2024
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Nov 19, 2024
@eihabkhan eihabkhan merged commit ea22fe7 into master Nov 19, 2024
@eihabkhan eihabkhan deleted the bump-pnpm-version branch November 19, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants