Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DARK: Aura > Disable logical properties postCSS plugin feature #92

Merged
merged 2 commits into from
Nov 21, 2024
Merged

DARK: Aura > Disable logical properties postCSS plugin feature #92

merged 2 commits into from
Nov 21, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Nov 21, 2024 •
edited
Loading

JIRA Ticket

DARK

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

To make sure that no breaks happen after this change, the best course of action is to visually check each component that was affected by this change, these components are:

  • cart
  • featured products
  • main
  • navbar
  • product-listing
  • product
  • thankyou
    Let's QA each of these

Cart

  • Summary box item price
Screenshot 2024-11-21 at 11 05 29 AM
  • table header & row cells
Screenshot 2024-11-21 at 11 06 00 AM

Featured Products

  • Section title
Screenshot 2024-11-21 at 11 08 42 AM

Main

  • Dropdown button
Screenshot 2024-11-21 at 11 12 16 AM

Navbar

  • Close drawer button
Screenshot 2024-11-21 at 11 12 57 AM

Product

  • product images splide list and thumbnail
Screenshot 2024-11-21 at 11 17 20 AM

Thank You

  • table rows and total
Screenshot 2024-11-21 at 11 18 06 AM

Note

Leave empty when you have nothing to say.

@eihabkhan1 eihabkhan1 self-assigned this Nov 21, 2024
@eihabkhan1 eihabkhan1 added the in progress Currently being developed. label Nov 21, 2024
@eihabkhan1 eihabkhan1 changed the title DARK: Disable logical properties postCSS plugin feature DARK: Aura > Disable logical properties postCSS plugin feature Nov 21, 2024
@bj-anas bj-anas mentioned this pull request Nov 21, 2024
Merged
5 tasks
@eihabkhan1 eihabkhan1 added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Nov 21, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review November 21, 2024 10:18
@bj-anas bj-anas added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Nov 21, 2024
@eihabkhan1 eihabkhan1 merged commit 9dcb89b into master Nov 21, 2024
@eihabkhan1 eihabkhan1 deleted the postcss-logical-disable-aura branch November 21, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bj-anas bj-anas bj-anas approved these changes

Assignees

@eihabkhan1 eihabkhan1

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan1 @bj-anas