Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH-183: Coupons with discount type of fixed are displayed as percentage #97

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

bj-anas
Copy link
Contributor

@bj-anas bj-anas commented Dec 3, 2024

JIRA Ticket

Ticket: TH-183.

Prerequisites

  • Check this branch locally and run pnpm run release
  • 3 new files will be generated in this format theme name + date + .zip
  • Upload generated file locally or in seller-area test env

QA Steps

  • Create coupon from seller-area (make sure to be type fixed)
  • Activate coupon from seller area & theme editor
  • In store-front: place an order and check the cart page
  • Set coupon code and click on Apply button
  • You should see the discount value + currency

Note

I have also fixed some CSS + content in Meraki theme related to the summary box of the cart page

@bj-anas bj-anas added the in progress Currently being developed. label Dec 3, 2024
@bj-anas bj-anas self-assigned this Dec 3, 2024
@bj-anas bj-anas added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Dec 3, 2024
@eihabkhan1 eihabkhan1 added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Dec 5, 2024
@bj-anas bj-anas merged commit 36b7686 into master Dec 5, 2024
@bj-anas bj-anas deleted the TH-183 branch December 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants