image/config: Add helpers for config and annotations (labels) #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an extension of my previous PR to add a `version` API. Basically, there are so many `Option<T>` to plow through to access the labels given an ImageConfiguration. Plus additionally it's more ergonomic to interact with `&str` and not `&String` in cases where auto-deref doesn't apply. I tried to extend the existing config, but what I hit is that because we deserialize the labels as `HashMap`, we don't necessarily preserve the order...which is probably its own bug. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
add-labels-getter
branch
from
1c695a1 to
18276c4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 24.66% 22.74% -1.93%
==========================================
Files 23 23
Lines 1885 2058 +173
Branches 935 1135 +200
==========================================
+ Hits 465 468 +3
- Misses 629 788 +159
- Partials 791 802 +11 |
saschagrunert
approved these changes
Sep 18, 2023
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Oct 3, 2023
This also relates to youki-dev/oci-spec-rs#143 Basically getting the version from the config requires a helper, this is a lot more convenient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of my previous PR to add a
versionAPI.Basically, there are so many
Option<T>to plow through to access the labels given an ImageConfiguration. Plus additionally it's more ergonomic to interact with&strand not&Stringin cases where auto-deref doesn't apply.I tried to extend the existing config, but what I hit is that because we deserialize the labels as
HashMap, we don't necessarily preserve the order...which is probably its own bug.