Rename os_version to os.version #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Forbes <tom@tomforb.es>
saschagrunert
approved these changes
Apr 15, 2024
utam0k
reviewed
Apr 15, 2024
| @@ -231,6 +231,8 @@ impl From<&str> for Os { | |||
| "aix" => Os::AIX, | |||
| "android" => Os::Android, | |||
| "darwin" => Os::Darwin, | |||
| // std::env::consts::OS returns "macos" instead of darwin | |||
| "macos" => Os::Darwin, | |||
There was a problem hiding this comment.
May I ask you to create another commit or PR about this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should be
os.versionlikeImageConfig?For example this is what Github container repo returns:
{ "schemaVersion": 2, "manifests": [ { "mediaType": "application/vnd.oci.image.manifest.v1+json", "digest": "sha256:b09d1eb75170275f0e465ed97e90718e596aab4a2413ba7eedcfb9f13580aca6", "size": 2015, "platform": { "architecture": "amd64", "os": "darwin", "os.version": "macOS 13.3" },Also the tests failed on MacOS. I fixed this by canonicalising the temporary directory as well:
Unfortunately
std::env::consts::OSreturnsmacosinstead of Darwin, so I added an extra arm to the match condition to handle this. This makesDefaultwork properly on MacOS.Same as #134