Change the type of size to be u64
#203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sizes cannot be negative. This is a semver break; and yes the type inference fallout is a minor annoyance, but this is a notable improvement for code which is accepting `Descriptor` objects and interacting with other things on the filesystem that operate in terms of `u64` typically. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
change-size-type
branch
from
5d925fe to
ad7b406
Compare
saschagrunert
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sizes cannot be negative.
This is a semver break; and yes the type inference fallout is a minor annoyance, but this is a notable improvement for code which is accepting
Descriptorobjects and interacting with other things on the filesystem that operate in terms ofu64typically.