Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default debug level #2736

Closed
zahash opened this issue Mar 23, 2024 · 1 comment
Closed

default debug level #2736

zahash opened this issue Mar 23, 2024 · 1 comment

Comments

@zahash
Copy link
Contributor

zahash commented Mar 23, 2024

in crates/youki/src/observability.rs there is this line

/// If not in debug mode, default level is warn to get important logs
#[cfg(not(debug_assertions))]
const DEFAULT_LOG_LEVEL: &str = "error";

it says the default level is warn but it is set to error.

should the comment be changed?

@zahash
Copy link
Contributor Author

zahash commented Mar 23, 2024

in any case, here is a PR #2737

@zahash zahash closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant