Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix observability default log level comment #2737

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

zahash
Copy link
Contributor

@zahash zahash commented Mar 23, 2024

No description provided.

@zahash zahash mentioned this pull request Mar 23, 2024
@codecov-commenter
Copy link

Codecov Report

Merging #2737 (e46628a) into main (a41a333) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2737   +/-   ##
=======================================
  Coverage   65.21%   65.21%           
=======================================
  Files         133      133           
  Lines       16981    16981           
=======================================
  Hits        11074    11074           
  Misses       5907     5907           

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 25, 2024
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!

@utam0k
Copy link
Member

utam0k commented Mar 25, 2024

Signed-off-by: zahash <zahash.z@gmail.com>
@zahash zahash force-pushed the fix-observability-default-log-level branch from e46628a to 14db0d8 Compare March 25, 2024 12:27
@zahash
Copy link
Contributor Author

zahash commented Mar 25, 2024

@utam0k

ok, i followed the instructions in https://github.com/containers/youki/pull/2737/checks?check_run_id=23010257131
can you check if i re-commited correctly?

@utam0k utam0k merged commit a51c03a into youki-dev:main Mar 25, 2024
28 checks passed
@zahash zahash deleted the fix-observability-default-log-level branch March 25, 2024 12:53
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants