Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] exclude the oci-runtime-test from the typos #2133

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Jul 5, 2023

The oci runtime test in Go is maintained separately and used as a submodule. For us, there is no reason to check the typos.

Signed-off-by: yihuaf <yihuaf@unkies.org>
@yihuaf yihuaf marked this pull request as ready for review July 5, 2023 23:03
@yihuaf yihuaf self-assigned this Jul 5, 2023
@yihuaf yihuaf requested a review from a team July 5, 2023 23:03
@codecov-commenter
Copy link

Codecov Report

Merging #2133 (93d9bf5) into main (71cb81a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2133   +/-   ##
=======================================
  Coverage   64.82%   64.82%           
=======================================
  Files         129      129           
  Lines       14768    14769    +1     
=======================================
+ Hits         9573     9574    +1     
  Misses       5195     5195           

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@YJDoc2 YJDoc2 merged commit f160afc into youki-dev:main Jul 6, 2023
@utam0k utam0k added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants