Increate musl CI test timeout to 20 #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2143 +/- ##
==========================================
- Coverage 64.83% 64.82% -0.01%
==========================================
Files 129 129
Lines 14769 14769
==========================================
- Hits 9575 9574 -1
- Misses 5194 5195 +1 |
|
We can try this, but I am suspecting that the |
yihuaf
approved these changes
Jul 6, 2023
|
Let us try increasing the timeout, if it still fails, then we can investigate more :) |
|
It seems you were correct, there is some kind of bug or flake which is causing the musl test to timeout... |
See #2144 for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently there were several cancellations in CI due to musl tests getting timed out. This increases timeout from 15->20 mins, as in most of those cases the test running is underway, and our unit tests should be finished within the increases 5 minutes.