(fix) podman e2e : Update workflow for new required deps, add vagrantfile #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
=======================================
Coverage 65.40% 65.41%
=======================================
Files 133 133
Lines 16942 16942
=======================================
+ Hits 11081 11082 +1
+ Misses 5861 5860 -1 |
YJDoc2
force-pushed
the
fix/podman_e2e
branch
from
3261a39 to
67ecda6
Compare
|
@lengrongfu may I ask you to take a look at this? |
utam0k
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
As for me, it looks good. But we have to wait for @lengrongfu's review.
lengrongfu
approved these changes
Feb 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some recent changes in how podman repo runs its e2e, and deps that are needed by latest main branch, our podman e2e CI are failing all its tests due to missing deps from about a week.
This PR updates the CI to include the missing deps, and also adds a vagrant file that allows running those tests locally without having to change host system, like we have for containerd e2e.
Someone please also verify that vagrantfile works , as even though I have tested it, I had run it iteratively, so could have possibly missed some changes that I did manually. As long as the
VAGRANT_VAGRANTFILE=Vagrantfile.podmane2e vagrant upcommand runs without any error, it should be ok. Note that the go download is expected to take some time, so there would not be any logs while that is running due to--quietflag.Thanks!
EDIT : I ran the podman e2e on this branch in my repo, and it shows the same number of failed test, as there were before all tests started failing : https://github.com/YJDoc2/youki/actions/runs/7942453846