Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seccomp: Use offset_of! #2763

Merged
merged 2 commits into from
Apr 18, 2024
Merged

seccomp: Use offset_of! #2763

merged 2 commits into from
Apr 18, 2024
+49 −4

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Apr 17, 2024

offset_of is better because it allows us not to consider the difference between arches.
https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#offset_of

@utam0k
seccomp: Use offset_of!
1401ac7 
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k requested a review from a team April 17, 2024 12:57
@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 17, 2024
YJDoc2
YJDoc2 reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick, otherwise lgtm.
Also, I think we should label all seccomp package related prs with experimental, and not use other labels for these, so the release notes will not mix youki changes with these.

experiment/seccomp/src/instruction/consts.rs Outdated Show resolved Hide resolved
@utam0k utam0k added kind/experimental `/experimental` and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 18, 2024
@utam0k @YJDoc2
Update experiment/seccomp/src/instruction/consts.rs
2e4bc5f 
Co-authored-by: Yashodhan <54112038+YJDoc2@users.noreply.github.com>
@YJDoc2 YJDoc2 merged commit 32e021e into youki-dev:main Apr 18, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YJDoc2 YJDoc2 YJDoc2 approved these changes

Assignees
No one assigned
Labels
kind/experimental `/experimental`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utam0k @YJDoc2