-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process test #2968
Add process test #2968
Conversation
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
I figure out why the test failed. I reproduced it on my PC.
But runc is, even if /test is not in rootfs, runc run is working.
If we add a test directory to the rootfs you use for testing, the tests will pass. Sorry, I don't understand the detailed code of runc or youki, but I think it looks like runc is creating the cwd directory in this line. What is the difference between the behavior of runc and youki? |
Hey, thanks for the ping, I'll try to take a look at this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, also there are several warnings from the CI check, please take a look
Hey @sat0ken , I took a look at the code and there are two things -
|
Also @sat0ken a small request, please ping/comment in the tracking issue before opening a e2e test PR, so we can properly keep track. I have added your current PRs, but please comment for future ones. Thanks! |
@YJDoc2 |
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Hey @sat0ken , There are some conflicts and I have left a comment above on the still failing tests, please take a look. |
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@YJDoc2 Hi, thank you for comment and support. I fixed conflict and code. Could you please check? |
@YJDoc2 Ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nitpicks, but overall looks good.
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>
@YJDoc2 Thank you for review and comments. I've fixed the code. Could you please check the code? |
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 Thanks
* Add process test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * rm unused imports Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix set env Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add mkdir for test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * set permision to /test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix my miss of delete Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * set process args to run test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix check process env Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix create cwd dir Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix err to set env value Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix err to append env value to default Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * delete unnecessary code Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix to compare variables Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove unused import Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix error message actual/expected val Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com> --------- Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com> Co-authored-by: Yashodhan Joshi <yjdoc2@gmail.com>
* Add process test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * rm unused imports Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix set env Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add mkdir for test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * set permision to /test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix my miss of delete Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * set process args to run test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix check process env Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix create cwd dir Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix err to set env value Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix err to append env value to default Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * delete unnecessary code Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix to compare variables Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove unused import Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix error message actual/expected val Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com> --------- Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com> Co-authored-by: Yashodhan Joshi <yjdoc2@gmail.com> Signed-off-by: Akiyama <akiakiskyhand@gmail.com>
This implements the process validation in #361.