Add test root readonly #2976

sat0ken · 2024-11-04T04:27:57Z

This implements the root_readonly_true validation in #361

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

YJDoc2

Hey, I think we need to break this in two tests - one with readonly true and other with false. We will have a corresponding test in the runtime test, which will check that read operation is successful (maybe create a file and validate the contents) and the the write access will be tested according to config's value.

This is small deviation from the go test, but I think this would be a better test.

tests/contest/runtimetest/src/tests.rs

tests/contest/runtimetest/src/main.rs

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

sat0ken · 2024-11-10T22:55:48Z

@YJDoc2 HI, I've fixed the code according to the comments. Could you please check the code?

YJDoc2

Hey, overall ok, but some changes needed.

tests/contest/runtimetest/src/main.rs

tests/contest/contest/src/tests/root_readonly_true/root_readonly_tests.rs

tests/contest/runtimetest/src/tests.rs

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

…o add-test-root-readonly

sat0ken · 2024-11-13T19:33:04Z

@YJDoc2 I fixed code, Could you please check the code?

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

sat0ken · 2024-11-14T19:46:12Z

@YJDoc2 Ping!

YJDoc2

some minor changes needed.

tests/contest/runtimetest/src/tests.rs

…adonly

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

sat0ken · 2024-11-24T10:09:51Z

@YJDoc2 Thank you for review and comments. I've fixed the code. Could you please check the code?

YJDoc2

One final change.

tests/contest/runtimetest/src/tests.rs

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

YJDoc2 · 2024-11-25T13:51:47Z

@sat0ken , can you merge/rebase the latest main? the test_inside_container function has changed, so this will error if merged in current state. Apart from that this is good to go, so once that is done I'll merge.

Thanks for all the efforts, and apologies for so many back-and-forths :)

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

…o add-test-root-readonly

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

sat0ken · 2024-11-25T14:31:33Z

@YJDoc2

can you merge/rebase the latest main?

Sure ! I worked it. Is this ok?

397a8c5

YJDoc2

LGTM!
Thanks for your efforts, and apologies for so many back-and-forth :)

* add test root readonly true Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix test group name Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove blank line Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove unused import Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove unnecessary return Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * separate test root readonly true and false Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * change test_dir_write_access to pub fn to use test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * check root readonly to use test_dir_write_access Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove blank line Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * separate two tests to root_readonly_true and root_readonly_false Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * change test_dir_read_access to pub fn to use test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix debug message and add check read access Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add root_readonly test to main Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add read access test when root readonly is false Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fox type err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove code err to raw os err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add CreateOptions Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> --------- Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

* add test root readonly true Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix test group name Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove blank line Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove unused import Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove unnecessary return Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * separate test root readonly true and false Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * change test_dir_write_access to pub fn to use test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * check root readonly to use test_dir_write_access Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove blank line Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * separate two tests to root_readonly_true and root_readonly_false Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * change test_dir_read_access to pub fn to use test Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix debug message and add check read access Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fix format err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add root_readonly test to main Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add read access test when root readonly is false Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * fox type err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * remove code err to raw os err Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> * add CreateOptions Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> --------- Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com> Signed-off-by: Akiyama <akiakiskyhand@gmail.com>

sat0ken added 8 commits October 25, 2024 00:17

add test root readonly true

df448c0

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fix test group name

acf161b

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fix format

87d1d26

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

remove blank line

69e88a2

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

Merge branch 'main' into add-test-root-readonly

f6ae143

remove unused import

e08b84a

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fix format err

8f667f2

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

remove unnecessary return

acc437c

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

YJDoc2 added the kind/test label Nov 5, 2024

YJDoc2 mentioned this pull request Nov 5, 2024

[Tracking Issue] Implement Integraion Tests #361

Open

60 tasks

YJDoc2 requested changes Nov 5, 2024

View reviewed changes

tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved

tests/contest/runtimetest/src/main.rs Outdated Show resolved Hide resolved

sat0ken added 6 commits November 10, 2024 20:09

separate test root readonly true and false

2175df7

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fix format err

e73746a

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

change test_dir_write_access to pub fn to use test

d582912

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

check root readonly to use test_dir_write_access

944c7d4

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fix format err

f1aeaea

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fix format err

903e415

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

YJDoc2 requested changes Nov 11, 2024

View reviewed changes

sat0ken added 7 commits November 13, 2024 07:18

remove blank line

a49ca55

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

separate two tests to root_readonly_true and root_readonly_false

81d6128

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

change test_dir_read_access to pub fn to use test

da0ccbb

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fix debug message and add check read access

c3c62fb

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

Merge branch 'main' into add-test-root-readonly

820fa1e

fix format err

80d2bc8

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

Merge branch 'add-test-root-readonly' of github.com:sat0ken/youki int…

b8ea96d

…o add-test-root-readonly

sat0ken added 2 commits November 15, 2024 02:04

Merge branch 'main' into add-test-root-readonly

08bdd7a

add root_readonly test to main

faf60dc

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

YJDoc2 requested changes Nov 23, 2024

View reviewed changes

tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved

tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved

YJDoc2 mentioned this pull request Nov 23, 2024

add kill test #2996

Open

sat0ken added 3 commits November 24, 2024 15:30

Merge branch 'main' of github.com:sat0ken/youki into add-test-root-re…

db6dc3c

…adonly

add read access test when root readonly is false

6171950

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

fox type err

6b762f7

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

YJDoc2 requested changes Nov 25, 2024

View reviewed changes

tests/contest/runtimetest/src/tests.rs Outdated Show resolved Hide resolved

sat0ken added 2 commits November 25, 2024 15:07

remove code err to raw os err

7361277

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

Merge branch 'main' into add-test-root-readonly

27dc56c

sat0ken added 3 commits November 25, 2024 23:07

merge main

881a75a

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

Merge branch 'add-test-root-readonly' of github.com:sat0ken/youki int…

397a8c5

…o add-test-root-readonly

add CreateOptions

c5cc238

Signed-off-by: sat0ken <15720506+sat0ken@users.noreply.github.com>

YJDoc2 approved these changes Nov 26, 2024

View reviewed changes

YJDoc2 merged commit 62e0eee into youki-dev:main Nov 26, 2024
27 checks passed

github-actions bot mentioned this pull request Nov 25, 2024

Release for v0.5.0 #2906

Merged

github-actions bot mentioned this pull request Jan 5, 2025

Bump youki from 0.1.0 to 0.5.0 kokyhm/kubespray#110

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test root readonly #2976

Add test root readonly #2976

sat0ken commented Nov 4, 2024

YJDoc2 left a comment

sat0ken commented Nov 10, 2024

YJDoc2 left a comment

sat0ken commented Nov 13, 2024 •

edited

Loading

sat0ken commented Nov 14, 2024

YJDoc2 left a comment

sat0ken commented Nov 24, 2024

YJDoc2 left a comment

YJDoc2 commented Nov 25, 2024

sat0ken commented Nov 25, 2024 •

edited

Loading

YJDoc2 left a comment

Add test root readonly #2976

Add test root readonly #2976

Conversation

sat0ken commented Nov 4, 2024

YJDoc2 left a comment

Choose a reason for hiding this comment

sat0ken commented Nov 10, 2024

YJDoc2 left a comment

Choose a reason for hiding this comment

sat0ken commented Nov 13, 2024 • edited Loading

sat0ken commented Nov 14, 2024

YJDoc2 left a comment

Choose a reason for hiding this comment

sat0ken commented Nov 24, 2024

YJDoc2 left a comment

Choose a reason for hiding this comment

YJDoc2 commented Nov 25, 2024

sat0ken commented Nov 25, 2024 • edited Loading

YJDoc2 left a comment

Choose a reason for hiding this comment

sat0ken commented Nov 13, 2024 •

edited

Loading

sat0ken commented Nov 25, 2024 •

edited

Loading