-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Discord link to docs #3005
Conversation
Hey @crmejia , thanks a lot or the PR! The change of youki-dev is great, but we might need a bit more discussion on discord - after joining the cncf, I believe the official community channel will shift to cncf slack channel once its created, so we might mark discord as deprecated or even remove. Need more discussion on our side so will update here after that. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small updates great :)
Hey @youki-dev/youki , if anyone can take another look at this, it'd be great. I have mentioned my opinion above, but will need at least a couple more opinions from the team before I do anything. |
The change is good and we can defer the discussion of discord to later. After we are clear on the requirements regarding to CNCF, we can make the necessary change at that point. I will approve the PR. @YJDoc2 go ahead and merge this if this also looks good with you. We can also bypass CI for this. |
I'm not able to amend the commit, if there are revisions I'll sign the new one. If not I'll make a dummy commit. |
Make senes. |
How about it?
|
Signed-off-by: Crismar Mejia <crismar.mejia@gmail.com>
Signed-off-by: Crismar Mejia <crismar.mejia@gmail.com>
That worked! Thank you. |
Howdy folks,
I was reading through the docs and found no mention of the Discord. I found the link on a tiny icon on the README. I think it would be good to add to the docs for more visibility. Please let me know what you think(i.e., different wording or don't want a whole page and just a link on the sidebar).
Bonus: found an old
containers.github.io/youki/
link in the code of conduct. Addresses #2967