Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Discord link to docs #3005

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Adding Discord link to docs #3005

merged 2 commits into from
Dec 18, 2024

Conversation

crmejia
Copy link
Contributor

@crmejia crmejia commented Nov 26, 2024

Howdy folks,

I was reading through the docs and found no mention of the Discord. I found the link on a tiny icon on the README. I think it would be good to add to the docs for more visibility. Please let me know what you think(i.e., different wording or don't want a whole page and just a link on the sidebar).

Bonus: found an old containers.github.io/youki/ link in the code of conduct. Addresses #2967

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 27, 2024

Hey @crmejia , thanks a lot or the PR! The change of youki-dev is great, but we might need a bit more discussion on discord - after joining the cncf, I believe the official community channel will shift to cncf slack channel once its created, so we might mark discord as deprecated or even remove. Need more discussion on our side so will update here after that. Thanks again!

Copy link

@onihilist onihilist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small updates great :)

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 28, 2024

Hey @youki-dev/youki , if anyone can take another look at this, it'd be great. I have mentioned my opinion above, but will need at least a couple more opinions from the team before I do anything.

@yihuaf
Copy link
Collaborator

yihuaf commented Nov 29, 2024

The change is good and we can defer the discussion of discord to later. After we are clear on the requirements regarding to CNCF, we can make the necessary change at that point.

I will approve the PR. @YJDoc2 go ahead and merge this if this also looks good with you. We can also bypass CI for this.

@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 2, 2024
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Dec 16, 2024

@crmejia , can you please sign the commit, so DCO check will pass? Thanks.
Also @utam0k , can you take a look to finalize the wording?

@crmejia
Copy link
Contributor Author

crmejia commented Dec 16, 2024

I'm not able to amend the commit, if there are revisions I'll sign the new one. If not I'll make a dummy commit.

@utam0k
Copy link
Member

utam0k commented Dec 17, 2024

Also @utam0k , can you take a look to finalize the wording?

Make senes.

@utam0k
Copy link
Member

utam0k commented Dec 17, 2024

I'm not able to amend the commit, if there are revisions I'll sign the new one. If not I'll make a dummy commit.

How about it?

$ git rebase HEAD~2 --signoff
$ git push --force-with-lease origin HEAD

Signed-off-by: Crismar Mejia <crismar.mejia@gmail.com>
Signed-off-by: Crismar Mejia <crismar.mejia@gmail.com>
@crmejia
Copy link
Contributor Author

crmejia commented Dec 17, 2024

That worked! Thank you.

@YJDoc2 YJDoc2 enabled auto-merge (squash) December 18, 2024 04:44
@YJDoc2 YJDoc2 merged commit 2b94fb4 into youki-dev:main Dec 18, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants