Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v0.5.0 #3016

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prepare for v0.5.0 #3016

wants to merge 1 commit into from

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Dec 9, 2024

No description provided.

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 9, 2024
@utam0k utam0k requested a review from a team December 9, 2024 12:51
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Dec 9, 2024

Hey,

  1. I think we need to bump to 0.5.0 as there is atleast one breaking change, see Release for v0.5.0 #2906
  2. If you can wait till tom, I will review the test part of the preserve fd PR today, and get it merged unless there are major changes required, so it can go in this release as well.

@utam0k
Prepare for v0.5.0
c057a63 
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k changed the title Prepare for v0.4.2 Prepare for v0.5.0 Dec 10, 2024
@utam0k
Copy link
Member Author

utam0k commented Dec 10, 2024

Hey,

  1. I think we need to bump to 0.5.0 as there is atleast one breaking change, see Release for v0.4.2 #2906
  2. If you can wait till tom, I will review the test part of the preserve fd PR today, and get it merged unless there are major changes required, so it can go in this release as well.

Make sense.

YJDoc2
YJDoc2 reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you have to update the version to 0.5.0 in the code. Also I have approved the preserve-fd PR, left a comment without merging, please take a look and we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YJDoc2 YJDoc2 YJDoc2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utam0k @YJDoc2