Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pidfile test #379

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add pidfile test #379

merged 1 commit into from
Oct 12, 2021

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Oct 12, 2021

This adds the pidfile test : which , for some reason, was failing for oci-runtime-tools in github actions. Now that I have implemented this, and it works, I am worried I have implemented it wrong 😄 😅
This test works on both local setup and GitHub actions.
Please take a look @utam0k @yihuaf

@YJDoc2 YJDoc2 requested review from utam0k and yihuaf October 12, 2021 10:35
@codecov-commenter
Copy link

Codecov Report

Merging #379 (3cc47a7) into main (d907c13) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   76.52%   76.47%   -0.06%     
==========================================
  Files          52       52              
  Lines        8210     8311     +101     
==========================================
+ Hits         6283     6356      +73     
- Misses       1927     1955      +28     

@utam0k
Copy link
Member

utam0k commented Oct 12, 2021

In runtime-tools, it does createruningstopped, but I feel this is enough for us since it seems to have nothing to do with the pid file.
https://github.com/opencontainers/runtime-tools/blob/59cdde06764be8d761db120664020f0415f36045/validation/pidfile/pidfile.go#L59-L64

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k utam0k merged commit ab525d5 into youki-dev:main Oct 12, 2021
@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Oct 12, 2021

Yes, I felt that checking it would take extra state checks which should not be relevant in an option of create command anyways, so I only added check for validating if container is created, and then the pid file.

In runtime-tools, it does create running stopped, but I feel this is enough for us since it seems to have nothing to do with the pid file.

@YJDoc2 YJDoc2 deleted the pidfile branch November 2, 2021 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants