Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running tbump on an outdated branch #20

Closed
dmerejkowsky opened this issue Jul 12, 2018 · 0 comments
Closed

Error when running tbump on an outdated branch #20

dmerejkowsky opened this issue Jul 12, 2018 · 0 comments

Comments

@dmerejkowsky
Copy link
Collaborator

If the branch you are on is not up-to-date when you run tbump you may end up with something like this:

$ git push origin master v1.2.41-alpha-2
...
 * [new tag]         v1.2.41-alpha-2 -> v1.2.41-alpha-2
 ! [rejected]        master -> master (non-fast-forward)

and then you have a problem.

If you run git pull --rebase at this moment, but then the tag will get detached from the history.

Worse, if you have a continuous integration, you may trigger a deployment build with the tag in the wrong place.

A nice way to fix this issue is to push the branch and the tag in two separate commands (pushing the tag last).

dmerejkowsky added a commit that referenced this issue Jul 12, 2018
This makes sure we don't create tags at the wrong place.

Fixes #20
@dmerejkowsky dmerejkowsky assigned Marwyn42 and unassigned Marwyn42 Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants