Use pyproject.toml as the configuration file #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is breaking backwards compatibility since it ditches `tbump.toml` and it replaces it with `pyproject.toml` Addresses your-tools#69
dmerejkowsky
requested changes
Sep 2, 2020
| # In order to minimize the number of changes that are needed for this switch | ||
| # we parse `pyproject.toml` and use it to create a new `tomlkit.Document()` with | ||
| # a flat structure | ||
| parsed_pyproject = tomlkit.loads(cfg_path.text())["tool"]["tbump"] |
There was a problem hiding this comment.
That's pretty clever but it will crash with KeyError if [tool] or [[tool.tbump]] section is messing
There was a problem hiding this comment.
True, but let's not forget that the PR was about implementing Option 2, i.e. only support pyproject.toml. In this case, tool.tbump should always be present :)))
That being said, handling the KeyError would probably make sense anyway, since the user might make a typo or something.
|
Also, per my comments in #69 , I think you should keep tests running with |
|
I've created a separated PR so we can merge the unrelated fixes (thanks for those, by the way :P) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the pull request so that the test can run in CI
Addresses #69