Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 #43

Merged
merged 12 commits into from
Jan 14, 2021
Merged

PHP 8 #43

merged 12 commits into from
Jan 14, 2021

Conversation

yourwebmaker
Copy link
Owner

@yourwebmaker yourwebmaker commented Nov 11, 2020 •
edited
Loading

closes #13

@yourwebmaker
Copy link
Owner Author

I'm waiting till doctrine/migrations#980 gets merged so we use the migrations with PHP 8

@yourwebmaker
Merge branch 'master' into php-8
eaa5154 
# Conflicts:
#	README.md
#	composer.lock
#	migrations/db-config.php
@yourwebmaker
Update dependencies.
3d2023e
@codecov-io
Copy link

Codecov Report

Merging #43 (3d2023e) into master (e133ba4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     93.32%   93.32%           
  Complexity      185      185           
=========================================
  Files            45       45           
  Lines           599      599           
=========================================
  Hits            559      559           
  Misses           40       40
Flag Coverage Δ Complexity Δ
phpunit 93.32% <100.00%> (ø) 0.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Infra/ServiceFactory/DoctrineFactory.php 100.00% <100.00%> (ø) 1.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e133ba4...3d2023e. Read the comment docs.

@yourwebmaker yourwebmaker marked this pull request as ready for review January 13, 2021 22:46
@yourwebmaker yourwebmaker requested a review from zerai January 13, 2021 22:46
@yourwebmaker
Copy link
Owner Author

@zerai ... could you please check if everything is ok so I can merge?

@yourwebmaker yourwebmaker self-assigned this Jan 13, 2021
@yourwebmaker yourwebmaker merged commit 80330f7 into master Jan 14, 2021
@yourwebmaker yourwebmaker deleted the php-8 branch January 14, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerai zerai zerai approved these changes

@viniciusss viniciusss viniciusss approved these changes

Assignees

@yourwebmaker yourwebmaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PHP 8
4 participants
@yourwebmaker @codecov-io @viniciusss @zerai