Skip to content

Commit

Permalink
node: depends on @HAS_FPU
Browse files Browse the repository at this point in the history
It requires either hardware or software emulated fpu, otherwise program
can fail with SIGILL for fp instructions emitted by the JIT compiler

See openwrt#1937, openwrt#2633, openwrt#2442, FS#1257 for details

From code snippet at deps/v8/src/mips/constants-mips.h

    #elif(defined(__mips_soft_float) && __mips_soft_float != 0)
    // This flag is raised when -msoft-float is passed to the compiler.
    // // Although FPU is a base requirement for v8, soft-float ABI is used
    // // on soft-float systems with FPU kernel emulation.
    // const bool IsMipsSoftFloatABI = true;

[1] https://bugs.chromium.org/p/v8/issues/detail?id=4704

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
  • Loading branch information
yousong committed Jan 29, 2018
1 parent f552f73 commit 07f454c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lang/node/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=node
PKG_VERSION:=v6.11.2
PKG_RELEASE:=3
PKG_RELEASE:=4
PKG_SOURCE:=node-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=http://nodejs.org/dist/${PKG_VERSION}
PKG_HASH:=04af4992238b19124ea56f1bcfda36827613a24eb3b00fc3b50f261a415a26e4
Expand All @@ -36,7 +36,7 @@ define Package/node
SUBMENU:=Node.js
TITLE:=Node.js is a platform built on Chrome's JavaScript runtime
URL:=http://nodejs.org/
DEPENDS:=+libstdcpp +libopenssl +zlib +USE_UCLIBC:libpthread +USE_UCLIBC:librt +NODEJS_ICU:icu
DEPENDS:=@(HAS_FPU||KERNEL_MIPS_FPU_EMULATOR) +libstdcpp +libopenssl +zlib +USE_UCLIBC:libpthread +USE_UCLIBC:librt +NODEJS_ICU:icu
endef

define Package/node/description
Expand Down

0 comments on commit 07f454c

Please sign in to comment.